-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise exception if rich is less than 10.2.2 #10839
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
hey @kaushikb11 thanks for bringing this up :) This is actually a pain I have had in the past with Flash, since a lot of the dependencies are quite touchy (specific versions and whatnot) it's hard to know the exact cause of the unavailability. I suggest following @awaelchli approach of combining the two together and mentioning that we require 10.2.2 and above :) |
What does this PR do?
Raise an exception if
rich
version is less than10.2.2
, or else it's very hard for the user to know the error.Discussed in #10702
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda @SeanNaren @kaushikb11