Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise exception if rich is less than 10.2.2 #10839

Merged
merged 4 commits into from
Dec 1, 2021
Merged

Raise exception if rich is less than 10.2.2 #10839

merged 4 commits into from
Dec 1, 2021

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Nov 30, 2021

What does this PR do?

Raise an exception if rich version is less than 10.2.2, or else it's very hard for the user to know the error.
Discussed in #10702

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @SeanNaren @kaushikb11

@kaushikb11 kaushikb11 added this to the 1.5.x milestone Nov 30, 2021
@kaushikb11 kaushikb11 added bug Something isn't working progress bar: rich labels Nov 30, 2021
@kaushikb11 kaushikb11 marked this pull request as ready for review November 30, 2021 13:43
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Nov 30, 2021
@SeanNaren
Copy link
Contributor

hey @kaushikb11 thanks for bringing this up :)

This is actually a pain I have had in the past with Flash, since a lot of the dependencies are quite touchy (specific versions and whatnot) it's hard to know the exact cause of the unavailability. I suggest following @awaelchli approach of combining the two together and mentioning that we require 10.2.2 and above :)

@kaushikb11 kaushikb11 enabled auto-merge (squash) December 1, 2021 05:28
@mergify mergify bot removed the has conflicts label Dec 1, 2021
@kaushikb11 kaushikb11 merged commit ec0fb2f into master Dec 1, 2021
@kaushikb11 kaushikb11 deleted the error/rich branch December 1, 2021 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working progress bar: rich ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants