-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify LSFEnvironment to use more reliable environment variable #10825
Conversation
- Use LSB_DJOB_RANKFILE to determine node rank and master address - Update tests
for more information, see https://pre-commit.ci
- Update CHANGELOG - Fix PEP8 violations
- Change master_address and master_port to main_address and main_port - Fix errors in mocks and tests
… into bugfix/lsf_env
for more information, see https://pre-commit.ci
… into bugfix/lsf_env
- this method never existed on ClusterEnvironment
… into bugfix/lsf_env
for more information, see https://pre-commit.ci
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions. |
9d0bf5a
to
dd88292
Compare
Out of curiosity, which release branch for Lightning are these changes expected to be released? 1.5.9? |
Co-authored-by: thomas chaton <thomas@grid.ai> Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: Andrew Tritt <andrew.j.tritt@gmail.com>
Co-authored-by: thomas chaton <thomas@grid.ai> Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: Andrew Tritt <andrew.j.tritt@gmail.com>
Co-authored-by: thomas chaton <thomas@grid.ai> Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: Andrew Tritt <andrew.j.tritt@gmail.com>
The environment variable
LSB_HOSTS
was being used to determine node rank and master address. This is not always populated. This PR updates LSFEnvironment to useLSB_DJOB_RANKFILE
instead.Fix #10216
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃