Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename special to standalone #10779

Merged
merged 3 commits into from
Nov 26, 2021
Merged

Rename special to standalone #10779

merged 3 commits into from
Nov 26, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Nov 26, 2021

What does this PR do?

Special was a confusing name. This PR uses standalone which represents better what it does.

Other candidates were:

single_process=True
split_process=True
separate_process=True

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @carmocca @akihironitta @Borda @justusschock @awaelchli

@carmocca carmocca added ci Continuous Integration refactor labels Nov 26, 2021
@carmocca carmocca added this to the 1.5.x milestone Nov 26, 2021
@carmocca carmocca self-assigned this Nov 26, 2021
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comments!

tests/utilities/test_warnings.py Outdated Show resolved Hide resolved
tests/trainer/test_trainer.py Show resolved Hide resolved
tests/special_tests.sh Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Nov 26, 2021
@justusschock justusschock enabled auto-merge (squash) November 26, 2021 15:58
@carmocca carmocca enabled auto-merge (squash) November 26, 2021 16:48
@carmocca carmocca merged commit 152eb57 into master Nov 26, 2021
@carmocca carmocca deleted the ci/special-to-standalone branch November 26, 2021 17:13
kaushikb11 pushed a commit that referenced this pull request Nov 30, 2021
lexierule pushed a commit that referenced this pull request Nov 30, 2021
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants