Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify hanging queue test #10591

Merged
merged 4 commits into from
Nov 17, 2021
Merged

Simplify hanging queue test #10591

merged 4 commits into from
Nov 17, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Nov 17, 2021 •
edited
Loading

What does this PR do?

This test is hanging in our CI, and we just need to check the deprecation warning

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @carmocca @akihironitta @Borda

@carmocca carmocca added the ci Continuous Integration label Nov 17, 2021
@carmocca carmocca added this to the 1.5.x milestone Nov 17, 2021
@carmocca carmocca self-assigned this Nov 17, 2021
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@mergify mergify bot added the ready PRs ready to be merged label Nov 17, 2021
@mergify mergify bot requested a review from a team November 17, 2021 16:29
@carmocca carmocca enabled auto-merge (squash) November 17, 2021 16:31
Borda
Borda approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to be careful with making it too large, then when it hangs it is killed at the timeout...
also, the need for extending timeout tells us that tests are taking significantly longer than before... 🐰

@carmocca carmocca marked this pull request as draft November 17, 2021 17:20
@carmocca carmocca changed the title Tune CI test timeouts Simplify hanging queue test Nov 17, 2021
@carmocca carmocca added tests and removed ci Continuous Integration labels Nov 17, 2021
@carmocca carmocca marked this pull request as ready for review November 17, 2021 17:32
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@carmocca carmocca enabled auto-merge (squash) November 17, 2021 17:38
@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #10591 (24c9b09) into master (ff3443f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10591   +/-   ##
=======================================
  Coverage      92%      92%           
=======================================
  Files         178      178           
  Lines       16246    16246           
=======================================
  Hits        14905    14905           
  Misses       1341     1341

@carmocca carmocca merged commit c15b84d into master Nov 17, 2021
@carmocca carmocca deleted the ci/cancelled-jobs branch November 17, 2021 22:29
carmocca added a commit that referenced this pull request Nov 22, 2021
@carmocca
Simplify hanging queue test (#10591)
654750e
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
@carmocca @Raalsky
Simplify hanging queue test (Lightning-AI#10591)
1a45e36
awaelchli pushed a commit that referenced this pull request Nov 24, 2021
@carmocca @awaelchli
Simplify hanging queue test (#10591)
72271ca
lexierule pushed a commit that referenced this pull request Nov 24, 2021
@carmocca @lexierule
Simplify hanging queue test (#10591)
024acd5
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Borda approved these changes

@ethanwharris ethanwharris ethanwharris approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@carmocca carmocca

Labels
ready PRs ready to be merged tests
Projects
None yet
Milestone
pl:1.5.x
Development

Successfully merging this pull request may close these issues.
4 participants
@carmocca @awaelchli @Borda @ethanwharris