-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support special test parametrizations #10569
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
force-pushed
the
ci/support-special-parametrizations-2
branch
from
November 16, 2021 18:02
11f19d9
to
65288a9
Compare
carmocca
force-pushed
the
ci/support-special-parametrizations-2
branch
from
November 16, 2021 18:20
65288a9
to
e3f71fe
Compare
carmocca
force-pushed
the
ci/support-special-parametrizations-2
branch
from
November 16, 2021 18:28
e3f71fe
to
5fd4fa5
Compare
This reverts commit e18e487.
carmocca
requested review from
awaelchli,
Borda,
justusschock,
kaushikb11,
rohitgr7,
SeanNaren,
tchaton and
williamFalcon
as code owners
November 16, 2021 19:02
SeanNaren
approved these changes
Nov 16, 2021
awaelchli
approved these changes
Nov 16, 2021
akihironitta
approved these changes
Nov 17, 2021
Raalsky
pushed a commit
to neptune-ai/pytorch-lightning
that referenced
this pull request
Nov 23, 2021
awaelchli
pushed a commit
that referenced
this pull request
Nov 24, 2021
lexierule
pushed a commit
that referenced
this pull request
Nov 24, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Second attempt after #10462
I have rolled back some of the parameterizations. If you know of any others, feel free to push a change to this PR.
The current list of tests is:
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
cc @carmocca @akihironitta @Borda