Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve instantiation problem with init_meta_context #10493

Merged
merged 29 commits into from
Nov 15, 2021
Merged

Resolve instantiation problem with init_meta_context #10493

merged 29 commits into from
Nov 15, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Nov 11, 2021 •
edited by SeanNaren
Loading

What does this PR do?

Closes #10323

This PR adds support for properly using init_meta_context with more complex model like the ones used within xformer: https://github.com/facebookresearch/xformers

This doesn't work with DDPSpawn right now.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton changed the title Add support for instance with init meta context Add support for xformer microGPT.py model Nov 12, 2021
@tchaton tchaton self-assigned this Nov 12, 2021
@tchaton tchaton added this to the 1.5.x milestone Nov 12, 2021
@tchaton tchaton added the bug Something isn't working label Nov 12, 2021
@tchaton tchaton marked this pull request as ready for review November 12, 2021 12:24
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

4 similar comments
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@tchaton tchaton changed the title Add support for xformer microGPT.py model Resolve instantiation problem with init_meta_context Nov 12, 2021
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

carmocca
carmocca approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top 3 weirdest code in our codebase 😂

@mergify mergify bot added the ready PRs ready to be merged label Nov 12, 2021
@tchaton tchaton enabled auto-merge (squash) November 12, 2021 17:50
@mergify mergify bot removed the has conflicts label Nov 12, 2021
rohitgr7
rohitgr7 approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

CHANGELOG.md Outdated Show resolved Hide resolved
awaelchli
awaelchli approved these changes Nov 15, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
pytorch_lightning/core/mixins/device_dtype_mixin.py Show resolved Hide resolved
pytorch_lightning/trainer/trainer.py Show resolved Hide resolved
pytorch_lightning/utilities/meta.py Outdated Show resolved Hide resolved
@tchaton tchaton merged commit 1de3539 into master Nov 15, 2021
@tchaton tchaton deleted the meta_improvement branch November 15, 2021 19:13
rohitgr7 pushed a commit that referenced this pull request Nov 16, 2021
@tchaton @rohitgr7
Resolve instantiation problem with init_meta_context (#10493)
16f4311
lexierule pushed a commit that referenced this pull request Nov 16, 2021
@tchaton @lexierule
Resolve instantiation problem with init_meta_context (#10493)
53ff840
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
@tchaton @Raalsky
Resolve instantiation problem with init_meta_context (Lightning-AI#10493
cf20304 
)
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaushikb11 kaushikb11 kaushikb11 left review comments

@awaelchli awaelchli awaelchli approved these changes

@SeanNaren SeanNaren SeanNaren approved these changes

@carmocca carmocca carmocca approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@tchaton tchaton

Labels
bug Something isn't working experimental ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.5.x
Development

Successfully merging this pull request may close these issues.

init_meta_context fails isinstance call (fails xFormers)
6 participants
@tchaton @awaelchli @SeanNaren @carmocca @rohitgr7 @kaushikb11