-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix overfit_batch sampler replacement logic #10486
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitgr7
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
November 12, 2021 07:05
Codecov Report
@@ Coverage Diff @@
## master #10486 +/- ##
=======================================
- Coverage 92% 92% -0%
=======================================
Files 178 178
Lines 16240 16239 -1
=======================================
- Hits 14901 14900 -1
Misses 1339 1339 |
tchaton
reviewed
Nov 12, 2021
carmocca
approved these changes
Nov 12, 2021
tchaton
approved these changes
Nov 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
awaelchli
approved these changes
Nov 15, 2021
rohitgr7
changed the title
fix overfit_batch sampler replacement logic
[blocked #10408] fix overfit_batch sampler replacement logic
Nov 15, 2021
rohitgr7
changed the title
[blocked #10408] fix overfit_batch sampler replacement logic
fix overfit_batch sampler replacement logic
Nov 15, 2021
rohitgr7
force-pushed
the
fix/overfit_sampler
branch
from
November 15, 2021 21:03
00294e5
to
a31cb42
Compare
rohitgr7
added a commit
that referenced
this pull request
Nov 16, 2021
Co-authored-by: thomas chaton <thomas@grid.ai>
lexierule
pushed a commit
that referenced
this pull request
Nov 16, 2021
Co-authored-by: thomas chaton <thomas@grid.ai>
Raalsky
pushed a commit
to neptune-ai/pytorch-lightning
that referenced
this pull request
Nov 23, 2021
Co-authored-by: thomas chaton <thomas@grid.ai>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #10457
The fix is that we check for
RandomSampler
to identify whether shuffling is happening or not.. instead we should check whether the sampler isSequentialSampler
or not.Also improved some similar tests a little bit
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃