Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shutdown workers on failure #10463

Merged
merged 7 commits into from
Nov 15, 2021
Merged

shutdown workers on failure #10463

merged 7 commits into from
Nov 15, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Nov 10, 2021 •
edited
Loading

What does this PR do?

Fixes #9390

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@tchaton tchaton mentioned this pull request Nov 10, 2021
Closed
@tchaton tchaton added this to the 1.5.x milestone Nov 10, 2021
@tchaton tchaton added the bug Something isn't working label Nov 10, 2021
carmocca
carmocca approved these changes Nov 11, 2021
View reviewed changes
tests/loops/test_loops.py Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Nov 12, 2021
awaelchli
awaelchli approved these changes Nov 12, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
tchaton and others added 2 commits November 12, 2021 12:28
@tchaton @awaelchli
Update CHANGELOG.md
9c26e34 
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
@tchaton
remove persistent_workers=False
31fa37d
@tchaton tchaton enabled auto-merge (squash) November 12, 2021 12:31
@mergify mergify bot removed the has conflicts label Nov 12, 2021
@tchaton tchaton merged commit ffb4006 into master Nov 15, 2021
@tchaton tchaton deleted the resolve_failure branch November 15, 2021 10:03
@cowwoc
Copy link
Contributor

cowwoc commented Nov 15, 2021

Thank you!

rohitgr7 pushed a commit that referenced this pull request Nov 16, 2021
@tchaton @rohitgr7
shutdown workers on failure (#10463)
40b8e35
lexierule pushed a commit that referenced this pull request Nov 16, 2021
@tchaton @lexierule
shutdown workers on failure (#10463)
391e0d6
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
@tchaton @Raalsky
shutdown workers on failure (Lightning-AI#10463)
dffa3a1
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cowwoc cowwoc cowwoc left review comments

@awaelchli awaelchli awaelchli approved these changes

@carmocca carmocca carmocca approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees
No one assigned
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.5.x
Development

Successfully merging this pull request may close these issues.

Ability to release resources associated with a DataLoader
5 participants
@tchaton @cowwoc @awaelchli @carmocca @rohitgr7