Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fault Tolerance] Don't check the len of a dataset, but its instance. #10432

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Nov 9, 2021

What does this PR do?

Parts of #10358

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2021

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2021

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@tchaton tchaton changed the title Fault Tolerant: Don't check the len, just the instance. [Fault Tolerance] Don't check the len of a dataset, but its instance. Nov 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2021

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@carmocca carmocca added this to the 1.5.x milestone Nov 9, 2021
@mergify mergify bot added the ready PRs ready to be merged label Nov 9, 2021
@tchaton tchaton enabled auto-merge (squash) November 9, 2021 14:47
@tchaton tchaton merged commit f1882aa into master Nov 9, 2021
@tchaton tchaton deleted the more_complex_samplers branch November 9, 2021 14:51
awaelchli added a commit that referenced this pull request Nov 9, 2021
lexierule pushed a commit that referenced this pull request Nov 9, 2021
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fault tolerance ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants