Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add support for numpy datatypes in tokensloader #401

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions src/litdata/streaming/item_loader.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,7 @@
import numpy as np
import torch

from litdata.constants import (
_TORCH_DTYPES_MAPPING,
)
from litdata.constants import _NUMPY_DTYPES_MAPPING, _TORCH_DTYPES_MAPPING
from litdata.streaming.serializers import Serializer
from litdata.utilities._pytree import PyTree, tree_unflatten
from litdata.utilities.encryption import Encryption, EncryptionLevel
Expand Down Expand Up @@ -281,7 +279,17 @@ def setup(
region_of_interest: Optional[List[Tuple[int, int]]] = None,
) -> None:
super().setup(config, chunks, serializers, region_of_interest)
self._dtype = _TORCH_DTYPES_MAPPING[int(config["data_format"][0].split(":")[1])]

serializer_name, dtype_index = self._data_format[0].split(":")
if serializer_name not in ["no_header_numpy", "no_header_tensor"]:
raise ValueError("The provided data format isn't supported.")

self._serializer_name = serializer_name
self._dtype = (
_TORCH_DTYPES_MAPPING[int(dtype_index)]
if serializer_name == "no_header_tensor"
else _NUMPY_DTYPES_MAPPING[int(dtype_index)]
)
if all(chunk["dim"] is None for chunk in self._chunks):
raise ValueError("The provided chunks isn't properly setup.")

Expand Down Expand Up @@ -350,7 +358,14 @@ def load_item_from_chunk(

buffer: bytes = self._buffers[chunk_index]
offset = self._dtype.itemsize * (index - begin) * self._block_size
return torch.frombuffer(buffer, dtype=self._dtype, count=self._block_size, offset=offset)

# These deserialize steps could be optimized using serializer class and passing other options as kwargs
if self._serializer_name == "no_header_tensor":
data = torch.frombuffer(buffer, dtype=self._dtype, count=self._block_size, offset=offset)
else:
data = np.frombuffer(buffer, dtype=self._dtype, count=self._block_size, offset=offset)
data = torch.from_numpy(data)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to return numpy as this is the format the user provided.

return data

def delete(self, chunk_index: int, chunk_filepath: str) -> None:
if os.path.exists(chunk_filepath):
Expand Down
Loading