Feat/add support for numpy datatypes in tokensloader #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #401 +/- ##
===================================
Coverage 78% 78%
===================================
Files 34 34
Lines 5045 5052 +7
===================================
+ Hits 3954 3960 +6
- Misses 1091 1092 +1 |
tchaton
approved these changes
Oct 28, 2024
src/litdata/streaming/item_loader.py
Outdated
| data = torch.frombuffer(buffer, dtype=self._dtype, count=self._block_size, offset=offset) | ||
| else: | ||
| data = np.frombuffer(buffer, dtype=self._dtype, count=self._block_size, offset=offset) | ||
| data = torch.from_numpy(data) |
There was a problem hiding this comment.
It might be better to return numpy as this is the format the user provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #400.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃