Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add e2e test for simple streaming server #247

Conversation

AdolfoVillalobos
Copy link
Contributor

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #67:

  • Added end-to-end test for the simple streaming server case, which was missing.

I hope I understood the issue correctly.! I'm entirely open to suggestions.

Did you have fun?

Yess. I hope I can contribute to this cool project :)

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84%. Comparing base (c1b6ad4) to head (d6ca0e3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #247   +/-   ##
===================================
  Coverage    84%    84%           
===================================
  Files        13     13           
  Lines      1056   1056           
===================================
  Hits        890    890           
  Misses      166    166           

Copy link
Collaborator

@aniketmaurya aniketmaurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks great @AdolfoVillalobos!! Added few comments.

tests/e2e/test_e2e.py Outdated Show resolved Hide resolved
tests/e2e/test_e2e.py Outdated Show resolved Hide resolved
@AdolfoVillalobos AdolfoVillalobos force-pushed the test/30-08-24-add-e2e-test-for-simple-streaming branch from 7c979ac to 98f7655 Compare August 30, 2024 07:54
@aniketmaurya aniketmaurya merged commit 11cfbf6 into Lightning-AI:main Aug 30, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

end-to-end tests
2 participants