Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

end-to-end tests #67

Closed
4 tasks done
aniketmaurya opened this issue Apr 25, 2024 · 3 comments · Fixed by #247
Closed
4 tasks done

end-to-end tests #67

aniketmaurya opened this issue Apr 25, 2024 · 3 comments · Fixed by #247
Assignees
Labels
ci / tests enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@aniketmaurya
Copy link
Collaborator

aniketmaurya commented Apr 25, 2024

Add end-to-end tests for:

@aniketmaurya aniketmaurya added enhancement New feature or request help wanted Extra attention is needed ci / tests labels Apr 25, 2024
@aniketmaurya aniketmaurya self-assigned this Apr 26, 2024
@aniketmaurya aniketmaurya added the good first issue Good for newcomers label May 31, 2024
@imsiddhant07
Copy link

Hi @aniketmaurya wanted to confirm the scope of contribution here.

With reference to

Dynamic batching with streaming - addressed by #68

I can see there was _unbatch_no_stream() unbatch() methods added to LitAPI() along with tests.

Is a similar contribution expected for single streaming as well, i.e. methods in LitAPI class as well as tests under e2e.

@aniketmaurya
Copy link
Collaborator Author

aniketmaurya commented Aug 27, 2024

hi @imsiddhant07! No it's not required to add anything in LitAPI. In the PR that you mentioned, the test was just a by-product.

TLDR; only e2e test is required.

@AdolfoVillalobos
Copy link
Contributor

Hello! I submitted #247 to handle a single streaming case. I hope I understood the case correctly. Let me know If I got something wrong please ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci / tests enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants