fix(chore): Resolve many html escape issues #772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @belcirelk I think this needs to be rebased with the current |
There was a problem hiding this comment.
Pull Request Overview
This PR addresses HTML escaping and unescaping issues across multiple template files to properly handle user names containing apostrophes or HTML characters, and prevent HTML code in reservation titles and descriptions from breaking page rendering.
- Adds proper HTML unescaping before JavaScript escaping for user names and reservation data in PDF generation
- Implements consistent HTML escaping for reservation titles and descriptions displayed in UI
- Removes redundant HTML escaping from form input values where it's automatically handled
- Updates user name handling in autocomplete functionality to properly decode HTML entities
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tpl/Reservation/pdf.tpl | Adds HTML unescaping before JavaScript escaping for user names, reservation titles, and descriptions in PDF generation |
| tpl/Dashboard/dashboard_reservation.tpl | Adds HTML escaping for reservation titles and HTML unescaping for user names in dashboard display |
| tpl/Ajax/user_details.tpl | Adds HTML unescaping for user names in popup details |
| tpl/Ajax/respopup.tpl | Adds HTML escaping for titles and descriptions, HTML unescaping for user names in reservation popups |
| tpl/Admin/Users/user-update.tpl | Removes redundant HTML escaping from form input values |
| tpl/Admin/Users/manage_users.tpl | Adds HTML unescaping for user names in user management table |
| tpl/Admin/Resources/manage_resources_user_permissions.tpl | Adds HTML unescaping for user names in resource permissions |
| tpl/Admin/Reservations/manage_reservations.tpl | Adds HTML escaping for titles/descriptions and HTML unescaping for user names |
| Pages/Ajax/AutoCompletePage.php | Adds HTML entity decoding for user names in autocomplete functionality |
The html characters are not (un)escaped properly in many TPLs. This fix the display of user names containing an apostrophe or html code. It also prevent the html display of the description and title of the reservation that can break the html pages. closes LibreBooking#762
JohnVillalovos
force-pushed
the
fix/resolve-html-encode-issues-dashboard
branch
from
46e9469 to
4d897e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The html characters are not (un)escaped properly in many TPLs. This fix the display of user names containing an apostrophe or html code. It also prevent the html display of the description and title of the reservation that
can break the html pages.
closes #762