First Name and Last Name containing an apostrophe are not displayed correctly

[belcirelk]

[x]: This is a bug and not a question.

[x]: I understand that the best way to resolve this issue is to solve it and propose a Pull Request.

Describe the bug**

User First Name and Last Name containing apostrophe are not displayed correctly at many places

To Reproduce**

Steps to reproduce the behavior:

1. Change the user first/last name for something like Jean D'Amour
2. The html code is displayed instead of the apostrophe.

Expected behavior**

Screenshots**

Here 2 examples

Additional context**

Specifications

• LibreBooking version 3.0.3

[belcirelk]

In the users table, ' is saved as ' while in the reservation table on it's original form. On the problematic pages, ' is filtered again in the tpl.

[belcirelk]

I have looked at the code and in most places it can be fixed directly in the tpl using the filtering functions. For example, if I take the manage reservations page I would use these 2 filters:

<td class="reservationTitle">{$reservation->Title|escape:'html'}</td>

{fullname first=$reservation->FirstName|unescape:'html' last=$reservation->LastName|unescape:'html' ignorePrivacy=true}

One big problem is that the user can input html code in the reservation fileds and it's not filtered and displayed, for example in the dashboard.

[github-actions]

This issue was marked stale because it has been open 60 days with no
activity. Please remove the stale label or comment on this issue. Otherwise,
it will be closed in 15 days.

As an open-source project, we rely on community contributions to
address many of the reported issues. Without a proposed fix or
active work towards a solution it is our policy to close inactive
issues. This is documented in CONTRIBUTING.md

How to keep this issue open:

• If you are still experiencing this issue and are willing to
  investigate a fix, please comment and let us know.
• If you (or someone else) can propose a pull request with a
  solution, that would be fantastic.
• Any significant update or active discussion indicating progress
  will also prevent closure.

We value your input. If you can help provide a fix, we'd be happy
to keep this issue open and support your efforts.

This is documented in CONTRIBUTING.md

https://github.com/LibreBooking/app/blob/develop/CONTRIBUTING.md

[belcirelk]

Will work on this.