forked from envoyproxy/envoy
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ci: Use upstream
envoy.code.check
(envoyproxy#19737)
This PR updates CI to use an upstream tool that integrates 4 of the current format CI checks: - flake8 - glint - shellcheck - yapf The tool can be run with: $ bazel run //tools/code:check # -- -c glint shellcheck python_yapf python_flake8 The -- --fix flag works for yapf only Also worth mentioning is that the following will only check changes against eg main (commits/branches/etc should work) $ bazel run //tools/code:check -- -s main This should allow us to use the tool in git hooks once enough of the checks have been integrated We can add more of the format checks to the tool after There are also various other planned improvements See https://github.com/envoyproxy/pytooling/milestones for general roadmap I would also like to rationalize the format check part of CI as we go (the pytest/tooling ci jobs can be removed fairly imminently) As the new tool produces quite a bit of logging ive had to make it run first - so as it doesnt bury the logs from other checkers For that reason, i added a message at the bottom of the log output to advise searching above A failing check run can be seen here: https://dev.azure.com/cncf/envoy/_build/results?buildId=103005&view=logs&j=c5dd2866-6ab3-5f3c-3a44-4cef0ec909b5&t=a9eb66d6-8944-5769-b3f7-476949dadcb8&l=7560 https://dev.azure.com/cncf/envoy/_build/results?buildId=103005&view=logs&j=c5dd2866-6ab3-5f3c-3a44-4cef0ec909b5&t=a9eb66d6-8944-5769-b3f7-476949dadcb8&l=7433 https://dev.azure.com/cncf/envoy/_build/results?buildId=103005&view=logs&j=c5dd2866-6ab3-5f3c-3a44-4cef0ec909b5&t=a9eb66d6-8944-5769-b3f7-476949dadcb8&l=7292 https://dev.azure.com/cncf/envoy/_build/results?buildId=103005&view=logs&j=c5dd2866-6ab3-5f3c-3a44-4cef0ec909b5&t=a9eb66d6-8944-5769-b3f7-476949dadcb8&l=124 https://dev.azure.com/cncf/envoy/_build/results?buildId=103005&view=logs&j=c5dd2866-6ab3-5f3c-3a44-4cef0ec909b5&t=a9eb66d6-8944-5769-b3f7-476949dadcb8&l=251 https://dev.azure.com/cncf/envoy/_build/results?buildId=103005&view=logs&j=c5dd2866-6ab3-5f3c-3a44-4cef0ec909b5&t=a9eb66d6-8944-5769-b3f7-476949dadcb8&l=7050 In addition to adding the envoy.code.check tool this PR also brings in newer versions of core libs that have been fixed/optimized/cleaned up significantly in this release release info/milestone for this PR https://github.com/envoyproxy/pytooling/milestone/1 https://github.com/envoyproxy/pytooling/releases/tag/2022-03-04.0 Next milestone is the next iteration of the dep.checker - mostly cleanups/fixes i think https://github.com/envoyproxy/pytooling/milestone/2 Signed-off-by: Ryan Northey <ryan@synca.io>
- Loading branch information
Showing
9 changed files
with
62 additions
and
251 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
load("//bazel:envoy_build_system.bzl", "envoy_package") | ||
load("//tools/base:envoy_python.bzl", "envoy_entry_point") | ||
load("@envoy_repo//:path.bzl", "PATH") | ||
|
||
licenses(["notice"]) # Apache 2 | ||
|
||
envoy_package() | ||
|
||
envoy_entry_point( | ||
name = "check", | ||
args = ["--path=%s" % PATH], | ||
pkg = "envoy.code.check", | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.