-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Use upstream envoy.code.check
#19737
Conversation
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
3dac769
to
02d502e
Compare
02d502e
to
749f6d3
Compare
envoy.format.check
envoy.format.check
oops - wrong PR! sorry! |
envoy.format.check
envoy.format.check
envoy.format.check
envoy.code.check
35eda0b
to
631a74d
Compare
a07a158
to
dac63b5
Compare
envoy.code.check
envoy.code.check
dac63b5
to
a256004
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
a256004
to
03a8b0c
Compare
Looks great /lgtm deps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This PR updates CI to use an upstream tool that integrates 4 of the current format CI checks: - flake8 - glint - shellcheck - yapf The tool can be run with: $ bazel run //tools/code:check # -- -c glint shellcheck python_yapf python_flake8 The -- --fix flag works for yapf only Also worth mentioning is that the following will only check changes against eg main (commits/branches/etc should work) $ bazel run //tools/code:check -- -s main This should allow us to use the tool in git hooks once enough of the checks have been integrated We can add more of the format checks to the tool after There are also various other planned improvements See https://github.com/envoyproxy/pytooling/milestones for general roadmap I would also like to rationalize the format check part of CI as we go (the pytest/tooling ci jobs can be removed fairly imminently) As the new tool produces quite a bit of logging ive had to make it run first - so as it doesnt bury the logs from other checkers For that reason, i added a message at the bottom of the log output to advise searching above A failing check run can be seen here: https://dev.azure.com/cncf/envoy/_build/results?buildId=103005&view=logs&j=c5dd2866-6ab3-5f3c-3a44-4cef0ec909b5&t=a9eb66d6-8944-5769-b3f7-476949dadcb8&l=7560 https://dev.azure.com/cncf/envoy/_build/results?buildId=103005&view=logs&j=c5dd2866-6ab3-5f3c-3a44-4cef0ec909b5&t=a9eb66d6-8944-5769-b3f7-476949dadcb8&l=7433 https://dev.azure.com/cncf/envoy/_build/results?buildId=103005&view=logs&j=c5dd2866-6ab3-5f3c-3a44-4cef0ec909b5&t=a9eb66d6-8944-5769-b3f7-476949dadcb8&l=7292 https://dev.azure.com/cncf/envoy/_build/results?buildId=103005&view=logs&j=c5dd2866-6ab3-5f3c-3a44-4cef0ec909b5&t=a9eb66d6-8944-5769-b3f7-476949dadcb8&l=124 https://dev.azure.com/cncf/envoy/_build/results?buildId=103005&view=logs&j=c5dd2866-6ab3-5f3c-3a44-4cef0ec909b5&t=a9eb66d6-8944-5769-b3f7-476949dadcb8&l=251 https://dev.azure.com/cncf/envoy/_build/results?buildId=103005&view=logs&j=c5dd2866-6ab3-5f3c-3a44-4cef0ec909b5&t=a9eb66d6-8944-5769-b3f7-476949dadcb8&l=7050 In addition to adding the envoy.code.check tool this PR also brings in newer versions of core libs that have been fixed/optimized/cleaned up significantly in this release release info/milestone for this PR https://github.com/envoyproxy/pytooling/milestone/1 https://github.com/envoyproxy/pytooling/releases/tag/2022-03-04.0 Next milestone is the next iteration of the dep.checker - mostly cleanups/fixes i think https://github.com/envoyproxy/pytooling/milestone/2 Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: kuochunghsu <kuochunghsu@pinterest.com>
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message:
This PR updates CI to use an upstream tool that integrates 4 of the current format CI checks:
Additional Description:
The tool can be run with:
$ bazel run //tools/code:check # -- -c glint shellcheck python_yapf python_flake8
The
-- --fix
flag works for yapf onlyAlso worth mentioning is that the following will only check changes against eg
main
(commits/branches/etc should work)$ bazel run //tools/code:check -- -s main
This should allow us to use the tool in git hooks once enough of the checks have been integrated
We can add more of the format checks to the tool after
There are also various other planned improvements
See https://github.com/envoyproxy/pytooling/milestones for general roadmap
I would also like to rationalize the format check part of CI as we go (the pytest/tooling ci jobs can be removed fairly imminently)
As the new tool produces quite a bit of logging ive had to make it run first - so as it doesnt bury the logs from other checkers
For that reason, i added a message at the bottom of the log output to advise searching above
A failing check run can be seen here:
In addition to adding the
envoy.code.check
tool this PR also brings in newer versions of core libs that have been fixed/optimized/cleaned up significantly in this releaserelease info/milestone for this PR
Next milestone is the next iteration of the dep.checker - mostly cleanups/fixes i think
https://github.com/envoyproxy/pytooling/milestone/2
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]