ci: Use upstream envoy.code.check
#19737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
phlax
force-pushed
the
tooling-upstream-format-check
branch
2 times, most recently
from
3dac769
to
02d502e
Compare
phlax
force-pushed
the
tooling-upstream-format-check
branch
from
02d502e
to
749f6d3
Compare
phlax
changed the title
envoy.format.checkenvoy.format.check
|
oops - wrong PR! sorry! |
phlax
changed the title
envoy.format.checkenvoy.format.check
phlax
changed the title
envoy.format.checkenvoy.code.check
phlax
force-pushed
the
tooling-upstream-format-check
branch
3 times, most recently
from
35eda0b
to
631a74d
Compare
phlax
force-pushed
the
tooling-upstream-format-check
branch
8 times, most recently
from
a07a158
to
dac63b5
Compare
phlax
changed the title
envoy.code.checkenvoy.code.check
phlax
force-pushed
the
tooling-upstream-format-check
branch
from
dac63b5
to
a256004
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
tooling-upstream-format-check
branch
from
a256004
to
03a8b0c
Compare
|
Looks great /lgtm deps |
repokitteh-read-only
bot
removed
the
deps
JuniorHsu
pushed a commit
to JuniorHsu/envoy
that referenced
this pull request
Mar 17, 2022
This PR updates CI to use an upstream tool that integrates 4 of the current format CI checks: - flake8 - glint - shellcheck - yapf The tool can be run with: $ bazel run //tools/code:check # -- -c glint shellcheck python_yapf python_flake8 The -- --fix flag works for yapf only Also worth mentioning is that the following will only check changes against eg main (commits/branches/etc should work) $ bazel run //tools/code:check -- -s main This should allow us to use the tool in git hooks once enough of the checks have been integrated We can add more of the format checks to the tool after There are also various other planned improvements See https://github.com/envoyproxy/pytooling/milestones for general roadmap I would also like to rationalize the format check part of CI as we go (the pytest/tooling ci jobs can be removed fairly imminently) As the new tool produces quite a bit of logging ive had to make it run first - so as it doesnt bury the logs from other checkers For that reason, i added a message at the bottom of the log output to advise searching above A failing check run can be seen here: https://dev.azure.com/cncf/envoy/_build/results?buildId=103005&view=logs&j=c5dd2866-6ab3-5f3c-3a44-4cef0ec909b5&t=a9eb66d6-8944-5769-b3f7-476949dadcb8&l=7560 https://dev.azure.com/cncf/envoy/_build/results?buildId=103005&view=logs&j=c5dd2866-6ab3-5f3c-3a44-4cef0ec909b5&t=a9eb66d6-8944-5769-b3f7-476949dadcb8&l=7433 https://dev.azure.com/cncf/envoy/_build/results?buildId=103005&view=logs&j=c5dd2866-6ab3-5f3c-3a44-4cef0ec909b5&t=a9eb66d6-8944-5769-b3f7-476949dadcb8&l=7292 https://dev.azure.com/cncf/envoy/_build/results?buildId=103005&view=logs&j=c5dd2866-6ab3-5f3c-3a44-4cef0ec909b5&t=a9eb66d6-8944-5769-b3f7-476949dadcb8&l=124 https://dev.azure.com/cncf/envoy/_build/results?buildId=103005&view=logs&j=c5dd2866-6ab3-5f3c-3a44-4cef0ec909b5&t=a9eb66d6-8944-5769-b3f7-476949dadcb8&l=251 https://dev.azure.com/cncf/envoy/_build/results?buildId=103005&view=logs&j=c5dd2866-6ab3-5f3c-3a44-4cef0ec909b5&t=a9eb66d6-8944-5769-b3f7-476949dadcb8&l=7050 In addition to adding the envoy.code.check tool this PR also brings in newer versions of core libs that have been fixed/optimized/cleaned up significantly in this release release info/milestone for this PR https://github.com/envoyproxy/pytooling/milestone/1 https://github.com/envoyproxy/pytooling/releases/tag/2022-03-04.0 Next milestone is the next iteration of the dep.checker - mostly cleanups/fixes i think https://github.com/envoyproxy/pytooling/milestone/2 Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: kuochunghsu <kuochunghsu@pinterest.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message:
This PR updates CI to use an upstream tool that integrates 4 of the current format CI checks:
Additional Description:
The tool can be run with:
$ bazel run //tools/code:check # -- -c glint shellcheck python_yapf python_flake8The
-- --fixflag works for yapf onlyAlso worth mentioning is that the following will only check changes against eg
main(commits/branches/etc should work)$ bazel run //tools/code:check -- -s mainThis should allow us to use the tool in git hooks once enough of the checks have been integrated
We can add more of the format checks to the tool after
There are also various other planned improvements
See https://github.com/envoyproxy/pytooling/milestones for general roadmap
I would also like to rationalize the format check part of CI as we go (the pytest/tooling ci jobs can be removed fairly imminently)
As the new tool produces quite a bit of logging ive had to make it run first - so as it doesnt bury the logs from other checkers
For that reason, i added a message at the bottom of the log output to advise searching above
A failing check run can be seen here:
In addition to adding the
envoy.code.checktool this PR also brings in newer versions of core libs that have been fixed/optimized/cleaned up significantly in this releaserelease info/milestone for this PR
Next milestone is the next iteration of the dep.checker - mostly cleanups/fixes i think
https://github.com/envoyproxy/pytooling/milestone/2
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]