Remove envoy.reloadable_features.remove_forked_chromium_url (envoypro…

…xy#18585) Fixes envoyproxy#18442 Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
LeonGao91 · Oct 13, 2021 · 08d2573 · 08d2573
1 parent b959637
commit 08d2573
Show file tree

Hide file tree

Showing 23 changed files with 16 additions and 1,455 deletions.
diff --git a/.bazelrc b/.bazelrc
@@ -158,7 +158,7 @@ build:coverage --strategy=CoverageReport=sandboxed,local
 build:coverage --experimental_use_llvm_covmap
 build:coverage --collect_code_coverage
 build:coverage --test_tag_filters=-nocoverage
-build:coverage --instrumentation_filter="//source(?!/common/chromium_url|/common/quic/platform)[/:],//include[/:]"
+build:coverage --instrumentation_filter="//source(?!/common/quic/platform)[/:],//include[/:]"
 build:test-coverage --test_arg="-l trace"
 build:fuzz-coverage --config=plain-fuzzer
 build:fuzz-coverage --run_under=@envoy//bazel/coverage:fuzz_coverage_wrapper.sh

diff --git a/ci/run_clang_tidy.sh b/ci/run_clang_tidy.sh
@@ -46,12 +46,6 @@ function exclude_check_format_testdata() {
   grep -v tools/testdata/check_format/
 }
 
-# Do not run clang-tidy against Chromium URL import, this needs to largely
-# reflect the upstream structure.
-function exclude_chromium_url() {
-  grep -v source/common/chromium_url/
-}
-
 # Exclude files in third_party which are temporary forks from other OSS projects.
 function exclude_third_party() {
   grep -v third_party/
@@ -83,7 +77,7 @@ function exclude_wasm_examples() {
 }
 
 function filter_excludes() {
-  exclude_check_format_testdata | exclude_chromium_url | exclude_win32_impl | exclude_macos_impl | exclude_third_party | exclude_wasm_emscripten | exclude_wasm_sdk | exclude_wasm_host | exclude_wasm_test_data | exclude_wasm_examples
+  exclude_check_format_testdata | exclude_win32_impl | exclude_macos_impl | exclude_third_party | exclude_wasm_emscripten | exclude_wasm_sdk | exclude_wasm_host | exclude_wasm_test_data | exclude_wasm_examples
 }
 
 function run_clang_tidy() {

diff --git a/docs/root/version_history/current.rst b/docs/root/version_history/current.rst
@@ -27,6 +27,7 @@ Removed Config or Runtime
 * http: removed ``envoy.reloadable_features.add_and_validate_scheme_header`` and legacy code paths.
 * http: removed ``envoy.reloadable_features.dont_add_content_length_for_bodiless_requests deprecation`` and legacy code paths.
 * http: removed ``envoy.reloadable_features.improved_stream_limit_handling`` and legacy code paths.
+* http: removed ``envoy.reloadable_features.remove_forked_chromium_url`` and legacy code paths.
 * http: removed ``envoy.reloadable_features.return_502_for_upstream_protocol_errors``. Envoy will always return 502 code upon encountering upstream protocol error.
 * http: removed ``envoy.reloadable_features.treat_upstream_connect_timeout_as_connect_failure`` and legacy code paths.
 * upstream: removed ``envoy.reloadable_features.upstream_host_weight_change_causes_rebuild`` and legacy code paths.

diff --git a/source/common/chromium_url/BUILD b/source/common/chromium_url/BUILD
diff --git a/source/common/chromium_url/LICENSE b/source/common/chromium_url/LICENSE
diff --git a/source/common/chromium_url/README.md b/source/common/chromium_url/README.md
diff --git a/source/common/chromium_url/envoy_shim.h b/source/common/chromium_url/envoy_shim.h
diff --git a/source/common/chromium_url/url_canon.cc b/source/common/chromium_url/url_canon.cc
diff --git a/source/common/chromium_url/url_canon.h b/source/common/chromium_url/url_canon.h