Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove envoy.reloadable_features.remove_forked_chromium_url #18585

Merged
merged 3 commits into from
Oct 13, 2021
Merged

Remove envoy.reloadable_features.remove_forked_chromium_url #18585

merged 3 commits into from
Oct 13, 2021

Conversation

dio
Copy link
Member

@dio dio commented Oct 12, 2021

Commit Message: Remove envoy.reloadable_features.remove_forked_chromium_url
Additional description: This removes source/common/chromium_url dir. cc. @htuch
Risk Level: Low
Testing: Updated
Docs Changes: N/A
Release Notes: Added
Platform-Specific Features: N/A
Fixes #18442

Signed-off-by: Dhi Aurrahman dio@rockybars.com

Fixes #18442

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
@dio
Copy link
Member Author

dio commented Oct 13, 2021

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #18585 (comment) was created by @dio.

see: more, trace.

Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, woohoo!

@davinci26
Copy link
Member

@mattklein123 to merge because DCO is somewhat broken

@mattklein123
Copy link
Member

Awesome!!!

@mattklein123 mattklein123 merged commit 08d2573 into envoyproxy:main Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

envoy.reloadable_features.remove_forked_chromium_url deprecation
4 participants