-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add account verification, improve login error messages, fix "account removal" and more #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/java/com/jerboa/ui/components/home/BottomNavActivity.kt
# Conflicts: # app/src/main/java/com/jerboa/ui/components/inbox/InboxActivity.kt
I did notice that the instance alive check fails in emulators due them not having ICMP support. Not sure what to do yet with that Hmm apparently some cellular providers also block ICMPs, ig it is not reliable enough to use it. What else should I do? check a API endpoint?? |
I am now using a different method to calculate instance is alive, which does not suffer from the issue with the previous method. studio64_HRvhBFR1mx.mp4 |
# Conflicts: # app/src/main/java/com/jerboa/ui/components/community/CommunityActivity.kt
# Conflicts: # app/src/main/java/com/jerboa/ui/components/home/HomeActivity.kt # app/src/main/java/com/jerboa/ui/components/report/comment/CreateCommentReportActivity.kt # app/src/main/java/com/jerboa/ui/components/report/post/CreatePostReportActivity.kt # app/src/main/res/values/strings.xml
twizmwazin
approved these changes
Aug 2, 2023
This was referenced Aug 4, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Account verification checks:
Not sure if email required check and account approval are needed even at this point.
Regarding the banned check I need some more info, see matrix
If there are any missing checks let me know rather add it here than later in SQL migrations
Currently it checks accounts in HomeActivity on startup and in every action requiring a account
It invalidates the account when the /site retrieval fails or when a authenticated user /site User portion is missing (JWT invalid).
This ended up being much bigger than I originally anticipated.
EMkIDe1n9l.mp4
This should fix the following:
fixes #1079
fixes #1057
fixes #1053
fixes #1004
fixes #931
fixes #547