-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enchance imageviewer: Downloadprogressbar, error placeholder + retry, large images subsampling, SVG support #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/res/values/strings.xml
twizmwazin
approved these changes
Aug 2, 2023
# Conflicts: # app/src/main/java/com/jerboa/Utils.kt # app/src/main/java/com/jerboa/api/Http.kt # app/src/main/res/values/strings.xml
# Conflicts: # app/build.gradle.kts
dessalines
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well, thx!
@@ -0,0 +1,19 @@ | |||
package com.jerboa.util.downloadprogress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wish these things were already built in to the http clients. oh well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we were recreating a bunch of imageloaders which were creating a bunch of HttpClients. This pr aims to solve this.
Loading bar example
studio64_kcQHmGd8PN.mp4
error failure
studio64_RvFLc7Fpxh.mp4
Large image subsampling
studio64_mpNOL3St41.mp4
ZoomableAsyncImage does have some slight issues. I can revert back to AsymcImage untill they are fixed.
see https://github.com/saket/telephoto/issues