Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix/LIVE-14247]: close banner after calling on cancel when disabled broadcast is enabled. #7940

Merged
merged 5 commits into from
Oct 22, 2024
+8 −2
Merged

[Fix/LIVE-14247]: close banner after calling on cancel when disabled broadcast is enabled. #7940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8ea6502
fix: close after calling on cancel
kallen-ledger Sep 27, 2024
e5f8a8b
chore: add changeset
kallen-ledger Sep 27, 2024
6c9ce63
fix: update test expected value
kallen-ledger Oct 9, 2024
4652e31
fix: update test
kallen-ledger Oct 15, 2024
a1147f6
chore: remove special space comment
kallen-ledger Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fresh-dolls-sin.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"ledger-live-desktop": patch
---

close drawer after cancel with disable broadcast
3 changes: 2 additions & 1 deletion apps/ledger-live-desktop/src/renderer/modals/Platform/Exchange/CompleteExchange/Body.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,8 @@ const Body = ({ data, onClose }: { data: Data; onClose?: () => void | undefined
if (!isSwapTransaction || (isSwapTransaction && !isDemo3Enabled)) {
const error = new DisabledTransactionBroadcastError();
setError(error);
return onCancel(error);
onCancel(error);
return onClose?.();
} else {
return handleTransactionResult(result, operation);
}
Expand Down
2 changes: 1 addition & 1 deletion apps/ledger-live-desktop/tests/specs/services/wallet-api.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ test("Wallet API methods @smoke", async ({ page }) => {
await drawer.selectCurrency("tether usd");
// Test name and balance for tokens
await expect(drawer.getAccountButton("tether usd", 2)).toContainText(
"Ethereum 3 (USDT)71.8174 USDT", // Special space present in the actual rendered element apparently
"Ethereum 3 (USDT)71.8174 USDT",
);
await drawer.back();

Expand Down
Loading