Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix/LIVE-14247]: close banner after calling on cancel when disabled broadcast is enabled. #7940

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

kallen-ledger
Copy link
Contributor

@kallen-ledger kallen-ledger commented Sep 27, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Screen.Recording.2024-09-27.at.12.47.23.mov

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@kallen-ledger kallen-ledger self-assigned this Sep 27, 2024
@kallen-ledger kallen-ledger requested a review from a team as a code owner September 27, 2024 11:10
Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
ledger-live-docs βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 30, 2024 9:09am
native-ui-storybook βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 30, 2024 9:09am
react-ui-storybook βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 30, 2024 9:09am
web-tools ❌ Failed (Inspect) Sep 30, 2024 9:09am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 30, 2024 9:09am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants