Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LIVE-11478] Support for Uniswap V3 plugin #7874

Merged
merged 9 commits into from
Oct 3, 2024
Merged

[LIVE-11478] Support for Uniswap V3 plugin #7874

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
00c8f8e
Add Uniswap Module to `hw-app-eth`
lambertkevin Sep 25, 2024
bbaaf68
Add uniswapV3 as resolution config parameter
lambertkevin Sep 25, 2024
48518f2
Use Uniswap module in Ledger Service
lambertkevin Sep 25, 2024
f42240e
Make `coin-evm` resolve Uniswap transactions
lambertkevin Sep 25, 2024
62794fa
Add Uniswap module tests
lambertkevin Sep 25, 2024
a8c1fe5
Fix crazy old "bug" regarding misformed hexastring
lambertkevin Sep 25, 2024
a2151f4
unimported
lambertkevin Sep 26, 2024
3818143
changeset
lambertkevin Sep 26, 2024
d754f16
Update doc
lambertkevin Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update doc
  • Loading branch information
@lambertkevin
lambertkevin committed Sep 26, 2024
commit d754f16fba4fd7122933d9a7feba24d77ae46427
3 changes: 2 additions & 1 deletion libs/ledgerjs/packages/hw-app-eth/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,11 +552,12 @@ Returns **ReturnType\<any>**&#x20;
Allows to configure precisely what the service need to resolve.
for instance you can set nft:true if you need clear signing on NFTs. If you set it and it is not a NFT transaction, it should still work but will do a useless service resolution.

Type: {nft: [boolean](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Boolean)?, externalPlugins: [boolean](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Boolean)?, erc20: [boolean](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Boolean)?, domains: [Array](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Array)\<DomainDescriptor>?}
Type: {nft: [boolean](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Boolean)?, externalPlugins: [boolean](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Boolean)?, erc20: [boolean](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Boolean)?, domains: [Array](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Array)\<DomainDescriptor>?, uniswapV3: [boolean](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Boolean)?}

#### Properties

* `nft` **[boolean](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Boolean)?**&#x20;
* `externalPlugins` **[boolean](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Boolean)?**&#x20;
* `erc20` **[boolean](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Boolean)?**&#x20;
* `domains` **[Array](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Array)\<DomainDescriptor>?**&#x20;
* `uniswapV3` **[boolean](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Boolean)?**&#x20;
Loading