-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LIVE-11478] Support for Uniswap V3 plugin #7874
[LIVE-11478] Support for Uniswap V3 plugin #7874
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
4 Skipped Deployments
|
892f78d
to
590ded4
Compare
789c0de
to
97c1a61
Compare
97c1a61
to
3c320c3
Compare
3c320c3
to
f6bb95d
Compare
f6bb95d
to
75bca6e
Compare
75bca6e
to
73327ff
Compare
Default behavior of `hw-app-eth` should still be set to false
73327ff
to
94841fa
Compare
94841fa
to
d754f16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
πͺ
Hey all, this PR seems to have caused some issues downstream for the NPM package. hw-app-eth/src/modules/Uniswap/index.ts imports from ethers which is not listed as a dependency of the package. It may have worked for you locally as it's listed under devDependencies? Another issues is that the listed ethers version is old, and the new one exposes utils differently (each method can be imported directly instead of the whole utils object). |
β Checklist
npx changeset
was attached.π Description
Adds support for the Uniswap Universal Router plugin specified here in
@ledgerhq/hw-app-eth
and activates it incoin-evm
β Context
π§ Checklist for the PR Reviewers