Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIVE-11478] Support for Uniswap V3 plugin #7874

Merged
merged 9 commits into from
Oct 3, 2024

Conversation

lambertkevin
Copy link
Contributor

@lambertkevin lambertkevin commented Sep 23, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • now supports communication with the Uniswap Universal Router plugin

πŸ“ Description

Adds support for the Uniswap Universal Router plugin specified here in @ledgerhq/hw-app-eth and activates it in coin-evm

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 26, 2024 9:07am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 9:07am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 9:07am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 9:07am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 9:07am

@live-github-bot live-github-bot bot added the ledgerjs Has changes in the ledgerjs open source libs label Sep 23, 2024
@lambertkevin lambertkevin force-pushed the feature/hw-app-eth-supports-uniswap-plugin branch from 892f78d to 590ded4 Compare September 23, 2024 09:17
@lambertkevin lambertkevin force-pushed the feature/hw-app-eth-supports-uniswap-plugin branch 3 times, most recently from 789c0de to 97c1a61 Compare September 23, 2024 10:21
@lambertkevin lambertkevin force-pushed the feature/hw-app-eth-supports-uniswap-plugin branch from 97c1a61 to 3c320c3 Compare September 23, 2024 10:35
@lambertkevin lambertkevin force-pushed the feature/hw-app-eth-supports-uniswap-plugin branch from 3c320c3 to f6bb95d Compare September 23, 2024 10:42
@lambertkevin lambertkevin force-pushed the feature/hw-app-eth-supports-uniswap-plugin branch from f6bb95d to 75bca6e Compare September 25, 2024 13:44
@lambertkevin lambertkevin changed the title [DRAFT] Uniswap V3 [LIVE-11478] Support for Uniswap V3 plugin Sep 25, 2024
@lambertkevin lambertkevin force-pushed the feature/hw-app-eth-supports-uniswap-plugin branch from 75bca6e to 73327ff Compare September 25, 2024 13:48
@lambertkevin lambertkevin marked this pull request as ready for review September 25, 2024 13:50
@lambertkevin lambertkevin requested a review from a team as a code owner September 25, 2024 13:50
@lambertkevin lambertkevin force-pushed the feature/hw-app-eth-supports-uniswap-plugin branch from 73327ff to 94841fa Compare September 26, 2024 08:42
Copy link
Contributor

@Wozacosta Wozacosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸͺ„

@lambertkevin lambertkevin merged commit 9c6e2c4 into develop Oct 3, 2024
54 of 55 checks passed
@lambertkevin lambertkevin deleted the feature/hw-app-eth-supports-uniswap-plugin branch October 3, 2024 08:41
@sterlu
Copy link

sterlu commented Oct 17, 2024

Hey all, this PR seems to have caused some issues downstream for the NPM package.

hw-app-eth/src/modules/Uniswap/index.ts imports from ethers which is not listed as a dependency of the package. It may have worked for you locally as it's listed under devDependencies?

Another issues is that the listed ethers version is old, and the new one exposes utils differently (each method can be imported directly instead of the whole utils object).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants