Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turborepo 2 Upgrade #7802

Merged
merged 6 commits into from
Sep 18, 2024
Merged

Turborepo 2 Upgrade #7802

merged 6 commits into from
Sep 18, 2024

Conversation

angusbayley
Copy link
Contributor

@angusbayley angusbayley commented Sep 12, 2024 •
edited by KVNLS
Loading

This is a replacement for #7769

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bugfixes, you can explain the previous behavior and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Sep 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 9:12am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 9:12am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 9:12am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 9:12am
web-tools ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2024 9:12am

@socket-security Socket Security
Copy link

socket-security bot commented Sep 12, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@aws-sdk/client-s3@3.651.0 Transitive: environment, filesystem +94 7.85 MB aws-sdk-bot
npm/@aws-sdk/lib-storage@3.651.0 Transitive: environment +31 1.41 MB amzn-oss, aws-sdk-bot, kuhe, ...2 more
npm/turbo@2.1.2 None 0 14.9 kB jaredpalmer, turbobot, vercel-release-bot

🚮 Removed packages: npm/turbo@1.10.1

View full report↗︎

@live-github-bot live-github-bot bot added tools Has changes in tools automation CI/CD stuff labels Sep 12, 2024
@angusbayley angusbayley force-pushed the fix/turborepo-2-upgrade-post-ci-refactor branch from e4c3167 to 3259a19 Compare September 12, 2024 09:39
@live-github-bot live-github-bot bot added tools Has changes in tools automation CI/CD stuff and removed tools Has changes in tools automation CI/CD stuff labels Sep 12, 2024
@angusbayley angusbayley changed the title Fix/turborepo 2 upgrade post ci refactor [DNM] Fix/turborepo 2 upgrade post ci refactor Sep 12, 2024
@angusbayley angusbayley mentioned this pull request Sep 12, 2024
Closed
3 tasks
@KVNLS KVNLS force-pushed the fix/turborepo-2-upgrade-post-ci-refactor branch 5 times, most recently from 1ae56bd to 50f02d3 Compare September 16, 2024 16:21
@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Sep 16, 2024
@KVNLS KVNLS force-pushed the fix/turborepo-2-upgrade-post-ci-refactor branch 7 times, most recently from 239f4e1 to d699ab3 Compare September 18, 2024 05:13
@KVNLS KVNLS changed the title [DNM] Fix/turborepo 2 upgrade post ci refactor Turborepo 2 Upgrade Sep 18, 2024
@KVNLS KVNLS marked this pull request as ready for review September 18, 2024 07:02
@KVNLS KVNLS requested a review from a team as a code owner September 18, 2024 07:02
@KVNLS
Copy link
Member

KVNLS commented Sep 18, 2024

Working workflow before I updated targeted branch for workflows: https://github.com/LedgerHQ/ledger-live/actions/runs/10907621828/job/30295998714?pr=7802

themooneer
themooneer previously approved these changes Sep 18, 2024
View reviewed changes
angusbayley
angusbayley commented Sep 18, 2024
View reviewed changes
Copy link
Contributor Author

@angusbayley angusbayley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I have a couple of questions that I left as comments in the diffs.

package.json Show resolved Hide resolved
tools/actions/turborepo-s3-cache/src/server.ts Outdated Show resolved Hide resolved
tools/actions/turborepo-s3-cache/src/server.ts Outdated Show resolved Hide resolved
apps/ledger-live-desktop/scripts/post-install.js Show resolved Hide resolved
tools/actions/build-checks/package.json Show resolved Hide resolved
@KVNLS KVNLS force-pushed the fix/turborepo-2-upgrade-post-ci-refactor branch from d699ab3 to 4f37954 Compare September 18, 2024 09:11
valpinkman
valpinkman requested changes Sep 18, 2024
View reviewed changes
Copy link
Member

@valpinkman valpinkman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something is broken with the turbo/pnpm aliases

CleanShot 2024-09-18 at 14 07 59@2x
CleanShot 2024-09-18 at 14 07 47@2x

My bad @KVNLS told me about the branches setup. all good

@KVNLS KVNLS merged commit 3113f0d into develop Sep 18, 2024
48 of 54 checks passed
@KVNLS KVNLS deleted the fix/turborepo-2-upgrade-post-ci-refactor branch September 18, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KVNLS KVNLS KVNLS left review comments

@valpinkman valpinkman valpinkman approved these changes

@themooneer themooneer Awaiting requested review from themooneer

Assignees

@angusbayley angusbayley

Labels
automation CI/CD stuff desktop Has changes in LLD tools Has changes in tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@angusbayley @KVNLS @valpinkman @themooneer