Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] Fix/turborepo 2 upgrade from scratch #7769

Closed
wants to merge 17 commits into from

Conversation

angusbayley
Copy link
Contributor

@angusbayley angusbayley commented Sep 6, 2024

⚠️ DNM flag applied until 92ecdf0 removed from the PR

Drafting a replacement PR for #7287 which

  • reduces diffs to only those relevant to this change
  • implements each of the changes as a purpose built commit just so others can read it a bit more easily

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bugfixes, you can explain the previous behavior and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 3:01pm
web-tools ❌ Failed (Inspect) Sep 11, 2024 3:01pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 3:01pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 3:01pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 3:01pm

@live-github-bot live-github-bot bot added the automation CI/CD stuff label Sep 6, 2024
Copy link

socket-security bot commented Sep 6, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/turbo@2.1.1 None 0 14.9 kB turbobot

🚮 Removed packages: npm/turbo@1.10.1

View full report↗︎

@angusbayley angusbayley changed the title Fix/turborepo 2 upgrade from scratch [DNM] Fix/turborepo 2 upgrade from scratch Sep 6, 2024
@angusbayley angusbayley force-pushed the fix/turborepo-2-upgrade-from-scratch branch 2 times, most recently from 774731f to 8cb1242 Compare September 6, 2024 14:43
@live-github-bot live-github-bot bot added the tools Has changes in tools label Sep 6, 2024
@angusbayley angusbayley force-pushed the fix/turborepo-2-upgrade-from-scratch branch 7 times, most recently from b5a9e58 to d5c313b Compare September 9, 2024 10:07
BREAKING CHANGE: upgraded turborepo to version 2, which includes breaking changes in the build process and configuration.
temp: add logging in turbo-affected

temp: hardcode the turbo version in turbo-affected

temp: hardcode the turbo version in the npx cmd

temp: rebuild affected action

temp: now get turbo version from package - keep logs in to observe it passed through

temp: remove logging
@angusbayley angusbayley force-pushed the fix/turborepo-2-upgrade-from-scratch branch from d5c313b to 02fabaf Compare September 9, 2024 10:12
@live-github-bot live-github-bot bot added the ui Has changes in the design system library label Sep 9, 2024
@angusbayley angusbayley force-pushed the fix/turborepo-2-upgrade-from-scratch branch from c799222 to 72dd9ff Compare September 9, 2024 13:21
@angusbayley angusbayley force-pushed the fix/turborepo-2-upgrade-from-scratch branch from 59ed78a to 0f4f97f Compare September 9, 2024 16:49
@angusbayley angusbayley force-pushed the fix/turborepo-2-upgrade-from-scratch branch from dd82571 to 41807cf Compare September 11, 2024 10:03
@angusbayley angusbayley force-pushed the fix/turborepo-2-upgrade-from-scratch branch from 67107a0 to 7845373 Compare September 11, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Has changes in tools ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants