Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update types for then command #41

Merged
merged 2 commits into from
Mar 21, 2020
Merged

Update types for then command #41

merged 2 commits into from
Mar 21, 2020

Conversation

Lakitna
Copy link
Owner

@Lakitna Lakitna commented Mar 19, 2020

Closes #40

  • Tests
  • Type definitions
  • Ready for merge

@Lakitna
Copy link
Owner Author

Lakitna commented Mar 19, 2020

@m4dc4p Could you please verify the new types? I have not tests for this stuff, so I would like to make sure that I've not introduced any regressions.

@m4dc4p
Copy link

m4dc4p commented Mar 19, 2020

I copied then.d.ts over the existing file in my node_modules. cypress started without complaint, my tests ran, and VS code doesn't report any errors. I think they are good!

Thanks so much!

@Lakitna Lakitna merged commit e9a3764 into develop Mar 21, 2020
This was referenced Mar 25, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add timeout option to then
2 participants
@Lakitna @m4dc4p