Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout option to then #40

Closed
m4dc4p opened this issue Mar 16, 2020 · 3 comments · Fixed by #41
Closed

Add timeout option to then #40

m4dc4p opened this issue Mar 16, 2020 · 3 comments · Fixed by #41
Labels
enhancement New feature or request

Comments

@m4dc4p
Copy link

m4dc4p commented Mar 16, 2020

The default then command accepts a timeout option. Can you extend your types to mirror (or import) the cypress types? In 4.1.0, this is the Timeoutable interface.

BTW I love this plugin. Thank you for writing it!

@m4dc4p m4dc4p added the enhancement New feature or request label Mar 16, 2020
@Lakitna
Copy link
Owner

Lakitna commented Mar 19, 2020

Huh, I've taken a look at it and it looks like I've totally missed then() being timeoutable.. It's been like that for at least three years according to the documentations git blame https://github.com/cypress-io/cypress-documentation/blame/develop/source/api/commands/then.md

I've also found a test I copied from the Cypress repo testing this exact thing so I'm confident that my then() is also timeoutable.

I'll also take this chance to get my then() types more in line with the defaults

@m4dc4p
Copy link
Author

m4dc4p commented Mar 19, 2020

I was still able to use retry and timeout, even w/o the correct types, but I'm not quite sure how. Thanks for looking at it!

@Lakitna
Copy link
Owner

Lakitna commented Mar 25, 2020

Released in 1.1.0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants