-
Notifications
You must be signed in to change notification settings - Fork 6
Additional optional features added: User management during import #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dasistwas
wants to merge
82
commits into
LafColITS:master
Choose a base branch
from
Wunderbyte-GmbH:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xml ), show list of users to import We are only halfway through
… instead of false
…e a backup without userdata
…, increased version number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @mackensen ,
we did a modernisation of the overall code base and added a new feature: Solve user conflicts upon restore. We implemented it in a way so that when you upgrade, nothing changes. Only if you activate the new features in the plugin settings an admin level, then the new features are activated. New features are:
Resolve user conflicts upon restore: Sometimes it happens, that user credentials from remote are slightly different to the ones on the local Moodle. Sometimes that causes the restore to fail. Cases are: Same username, different e-mail, and similar. So we integrated a check and then provide to solve the conflicts: Either merge the user with existing user, or create a new user or just ignore the user and remove the user from the restore process.
We added the possibility to choose between username or idnumber for users being matched between local and remote host. Example: If your local admin hast a different username than on the remote, you can now just enter the idnumber (optional user profile fields) so that these match on local and remote. Then you can safely perform the import.
I did a rebase with your changes, so the merge can be done automatically. Tested for Moodle 3.5 to Moodle 3.9. Also travis is happy.
I hope you can merge those changes and if you have any questions, just contact me.
Kind regards,
David