[pull] main from docker:main #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Bumps [github.com/containerd/containerd](https://github.com/containerd/containerd) from 1.5.10 to 1.5.13. - [Release notes](https://github.com/containerd/containerd/releases) - [Changelog](https://github.com/containerd/containerd/blob/main/RELEASES.md) - [Commits](containerd/containerd@v1.5.10...v1.5.13) --- updated-dependencies: - dependency-name: github.com/containerd/containerd dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
We should not rely on having a global path for the Docker CLI socket. On macOS this forces Docker Desktop to access directories which require raised privileges. Whereas on Linux we do not create sockets in that location at all, currently. So look for the Docker CLI socket in the User's home directory. Signed-off-by: Piotr Stankiewicz <piotr.stankiewicz@docker.com>
Signed-off-by: Piotr Stankiewicz <piotr.stankiewicz@docker.com>
Use Docker CLI socket from home
…/containerd/containerd-1.5.13 Bump github.com/containerd/containerd from 1.5.10 to 1.5.13
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
Prepare for future updates of Go, which may result in some changes in formatting in GoDoc comments. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
update gotest.tools to v3.3.0 which support golang 1.18
DD relies on having the CLI socket available in /var/run when running in WSL. So in case we can't find the CLI socket in the calling user's home directory, fall back to /var/run. Signed-off-by: Piotr Stankiewicz <piotr.stankiewicz@docker.com>
Fall back to global CLI socket on Linux
…thub.com/crazy-max/compose-cli into cli-binary-path-handling Signed-off-by: Nick Sieger <nick@nicksieger.com>
1. Use path from env variable `$DOCKER_COM_DOCKER_CLI` 2. Use path formed from parent directory of current process joined with `com.docker.cli` 3. Look for `com.docker.cli` on $PATH Signed-off-by: Nick Sieger <nick@nicksieger.com>
To avoid any conflict with the CLI, use the `plugins` section of the config. This section is read and saved by the CLI without the risk to remove the value in there. So it's a safe way to deal with this feature. As it's a cross plugin configuration (now for scout but goal is wider than that) then put it under a generic `-x-cli-hints` name so that other plugins might use it if needed. Value can be true/false, but is parsed against these exact two values instead of using the ParseBool. Both the environment variable and the config value are parsed the same way. Signed-off-by: Yves Brissaud <yves.brissaud@docker.com>
Signed-off-by: Yves Brissaud <yves.brissaud@docker.com>
the same way we check --progress flag, if it exists, disable Signed-off-by: Yves Brissaud <yves.brissaud@docker.com>
feat: display docker scout hints on build and pull
compose-cli: fix PAT detection for PAT suggestion
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
The `docker scout quickview` hint, displayed after a user pulls or builds an image, only works if the user is logged in to Hub. Check if user isn't logged in, and make hint more explicit in this case. Signed-off-by: Laura Brehm <laurabrehm@hey.com>
Signed-off-by: aevesdocker <allie.sadler@docker.com>
update retire notice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )