This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
Go 1.18 #2174
Merged
Go 1.18 #2174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
aci
ci
crazy-max
force-pushed
the
go-1.18
branch
2 times, most recently
from
a342738 to
32429f1
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I plan to switch from shelling out to retrieve docker cli version by using the
debug/buildinfomodule in #2151 that will give resp time <1ms but this package is available since Go 1.18: crazy-max@ec18d50Also upgrading to Go 1.18 will slightly improve response time of the compose-cli itself:
cc @tonistiigi @glours @rumpl
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com