Update language in apps to use "Storage" instead of "Freezer" #1055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to "Storage" instead of "Freezer"
…lass for radio input fields
This was referenced Dec 14, 2022
cnathe
approved these changes
Dec 14, 2022
cnathe
reviewed
Dec 15, 2022
Comment on lines
+93
to
+94
| if (!showLabel) | ||
| return null; |
There was a problem hiding this comment.
@labkey-susanh sorry for the late update on this, but I just noticed that these two lines of code are causing display issues with the details panel edit mode (see here from LKB Registry molecules details panel edit, but also seen with samples detail edit ). When I comment out these two lines, the form inputs placement returns to the expected place.
There was a problem hiding this comment.
Thanks for the heads up. Fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
We want to make it more clear within the application that our storage management capabilities can support temperature-controlled as well as room-temperature storage. Thus we're updating the language in the applications to refer to the primary storage units more generically as "Storage" instead of "Freezers".
Related Pull Requests
Changes