Add Primary Storage as a StorageItemType #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnathe
approved these changes
Dec 14, 2022
| * Create a new LabKey Freezer Manager storage item that can be used in the creation of a storage hierarchy. | ||
| * Storage hierarchies consist of a top level Freezer or Primary Storage, which can have any combination of | ||
| * child non-terminal storage locations (i.e. those that do not directly contain samples but can contain other | ||
| * units) and terminal storage locations (i.e. units in the freezer that directly contain samples and cannot contain |
There was a problem hiding this comment.
Suggested change
| * units) and terminal storage locations (i.e. units in the freezer that directly contain samples and cannot contain | |
| * units) and terminal storage locations (i.e. units in the storage location that directly contain samples and cannot contain |
cnathe
reviewed
Dec 15, 2022
labkey-client-api/src/org/labkey/remoteapi/storage/CreateCommand.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
We want to make it more clear within the application and our APIs that our storage management capabilities can support temperature-controlled as well as room-temperature storage. Thus we're updating the language in the applications to refer to the primary storage units more generically as "Storage" instead of "Freezers".
Related Pull Requests
Changes
PrimaryStorageas a newStorageItemTypesequivalent toFreezerfrom room-temp storage