Skip to content

Add constants for common licenses, update to Gradle 7.1, and fix check for tomcat plugin #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 16, 2021

Conversation

labkey-susanh
Copy link
Contributor

Rationale

As we begin to use the BuildUtils.addExternalDependency in order for Gradle to produce the jars.txt files for us, we can use some constants for common licenses and URLs.

The check for the existence of the tomcat plugin was not quite right, causing cleanDeploy and cleanBuild to no longer do a shutdown of tomcat, leaving the dev environment in an unhappy state.

Related Pull Requests

#123

Changes

  • Add some constants helpful for declaring external dependencies
  • Fix check for tomcat plugin so cleanBuild and cleanDeploy will stop tomcat if available
  • Update to gradle 7.1

@labkey-susanh labkey-susanh merged commit 7892542 into develop Jun 16, 2021
@labkey-susanh labkey-susanh deleted the fb_versionUpdates217 branch June 16, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants