DisplayColumn refactor #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-matthewb
approved these changes
Mar 14, 2025
labkey-matthewb
approved these changes
Mar 14, 2025
Collaborator
|
hi @labkey-adam , so is the idea here that we need to migrate code to use the HtmlWriter, not Writer? I see the method passes both now - is this an interim stage that will ultimately be deprecated? |
Author
@bbimber Yes, exactly. The primary goal is to convert all the awkward, unsafe String-based HTML generation into DOM and builders. Plenty of examples in DataRegion (which is now completely migrated) and DisplayColumn (migrated except for three methods). |
* Finish renderGridCellContents migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Migrate
WritertoHtmlWriterRelated Pull Requests