-
Notifications
You must be signed in to change notification settings - Fork 1
Finish migration #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish migration #342
Conversation
SequenceAnalysis/src/org/labkey/sequenceanalysis/query/GenbankDisplayColumnFactory.java
Outdated
Show resolved
Hide resolved
SequenceAnalysis/src/org/labkey/sequenceanalysis/query/SequenceAnalysisCustomizer.java
Outdated
Show resolved
Hide resolved
SequenceAnalysis/src/org/labkey/sequenceanalysis/query/SequenceAnalysisUserSchema.java
Outdated
Show resolved
Hide resolved
SequenceAnalysis/src/org/labkey/sequenceanalysis/query/SequenceAnalysisUserSchema.java
Outdated
Show resolved
Hide resolved
SequenceAnalysis/src/org/labkey/sequenceanalysis/query/GenbankDisplayColumnFactory.java
Show resolved
Hide resolved
labkey-adam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few thoughts below, all totally optional
Your delimiter approach should work. I might instead do something like: |
@labkey-adam: does this seem like a reasonable approach to finish this migration?
Some specific questions:
delimiter a reasonable way to migrate? It used to use a simple string.
If this seems OK, it can merge into your fb_htmlwriter branch.