Skip to content

Conversation

@bbimber
Copy link
Collaborator

@bbimber bbimber commented Mar 15, 2025

@labkey-adam: does this seem like a reasonable approach to finish this migration?

Some specific questions:

  1. Is using PageFlowUtil.link() a reasonable class for all simple tags?
  2. SequenceAnalysisCustomizer ~line 271-279: is that pattern for the
    delimiter a reasonable way to migrate? It used to use a simple string.

If this seems OK, it can merge into your fb_htmlwriter branch.

@bbimber bbimber requested a review from labkey-adam March 15, 2025 20:58
Copy link

@labkey-adam labkey-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few thoughts below, all totally optional

@labkey-adam
Copy link

@labkey-adam: does this seem like a reasonable approach to finish this migration?

Some specific questions:

  1. Is using PageFlowUtil.link() a reasonable class for all simple tags?
  2. SequenceAnalysisCustomizer ~line 271-279: is that pattern for the delimiter a reasonable way to migrate? It used to use a simple string.

If this seems OK, it can merge into your fb_htmlwriter branch.

Your delimiter approach should work. I might instead do something like:

// Calculate once and stash it
private static final HtmlString COMMA = HtmlStringBuilder.of(",").append(HtmlString.BR).getHtmlString();
...
// Inside the loop
delim = COMMA;

@bbimber bbimber merged commit 676ff32 into LabKey:fb_htmlwriter Mar 16, 2025
1 check passed
@bbimber bbimber deleted the fb_htmlwriter2 branch March 16, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants