Skip to content

Dependency version updates for 21.7 #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 16, 2021
Merged

Conversation

labkey-susanh
Copy link

Rationale

Keeping dependency versions updated. We also take this opportunity to transition the module that is being updated to use the new BuildUtils.addExternalDependency method that provides the information to be used in populating the jars.txt file so we can remove it from and ignore it in git.

Related Pull Requests

Changes

  • Use BuildUtils.addExternalDependency, bringing in version updates.

@bbimber
Copy link
Collaborator

bbimber commented Jun 15, 2021

@labkey-susanh Does this mean no more manually maintaining jars.txt?

@labkey-susanh
Copy link
Author

@bbimber Yes, the new utility method gets rid of the need to do that by merging the data from the jars.txt into the build.gradle file, but I've not updated all the build.gradle files to use it, only the ones that have been touched by the dependency updates going on in platform at the moment. You have to convert all external dependencies to use this or none of them, can't have a mixture of both.

@bbimber
Copy link
Collaborator

bbimber commented Jun 15, 2021

ok, cool. i like that.

@labkey-susanh labkey-susanh merged commit 84998b1 into develop Jun 16, 2021
@labkey-susanh labkey-susanh deleted the fb_versionUpdates217 branch June 16, 2021 20:47
bbimber added a commit that referenced this pull request Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants