fix(readme): #95 Fix example in readme#96
fix(readme): #95 Fix example in readme#96UpperLeftHandSide wants to merge 1 commit intoLSXPrime:masterfrom
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||||||
There was a problem hiding this comment.
Welcome to SoundFlow repository! We appreciate you taking the time to contribute.
We're excited to review your pull request and look forward to collaborating with you. Please let us know if you have any questions or need any assistance.
Thank you for your contribution!
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
|
Good morning. Firstly, thanks for your interest in this project. I have forgotten to update the examples in the README and the main documentation homepage for v1.2.0. However, for the README, with the new v1.3.0 update, I already did the following:
Now, regarding the examples, maybe you can modify the documentation main page instead? It will be the new one-step example for newcomers. The file is located at: GettingStarted.tsx This reorganization was necessary because we got two new packages to be added under the "Extensions" section (FFMpeg & PortMidi). This was making the README file huge and distracting (it already was). |
|
I can probably take a peek at updating that documentation tomorrow. Are you suggesting I place the contents of the updated README example into that page, or something else? My apologies, I'm not super familiar with the library/project quite yet. I've only just started testing it out. |
Exactly, it's also available here for reference. The new version (v1.3.0) is ready to release—hopefully—and I'm finishing up the updated documentation. If you're busy, I might upload it today or tomorrow, all in the spirit of hope. I'll close this now, but feel free to reply if you have any new updates. |
User description
addresses #95
I was trying to test out this library and noticed the example didn't compile. Please let me know if you would prefer something else end up in the readme.
PR Type
Bug fix, Documentation
Description
Fix variable name inconsistency in README example
Replace incorrect
devicereferences withplaybackDeviceEnsure example code compiles and runs correctly
Diagram Walkthrough
File Walkthrough
README.md
Fix variable naming in audio playback exampleREADME.md
devicetoplaybackDevicein 4 locations