fix: GC hole in MiniAudioDecoder#47
Merged
LSXPrime merged 2 commits intoLSXPrime:masterfrom Jun 2, 2025
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to SoundFlow repository! We appreciate you taking the time to contribute.
We're excited to review your pull request and look forward to collaborating with you. Please let us know if you have any questions or need any assistance.
Thank you for your contribution!
Contributor
Author
|
Hopefully this fixes #45, though I cannot know if it will do so. |
Owner
|
Good evening, and thanks for your contribution. I'll pull and test it once I'm done with my current feature commit. I'll make sure it's merged before the next package update. Apologies for the delay. |
LSXPrime
approved these changes
Jun 2, 2025
LSXPrime
changed the title
Owner
|
Thanks for your efforts on this, Merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pointer returned from GetNativeBufferPointer was from an array that was only pinned inside the method, and was free to move outside of that fixed block. Outside of just fixing a GC hole, having it return the array to be pinned as a span allows it to both be much simpler while also not having to worry about management of those arrays in Dispose.