refactor: Raw audio sample support for AssetDataProvider#43
refactor: Raw audio sample support for AssetDataProvider#43LSXPrime merged 3 commits intoLSXPrime:masterfrom
Conversation
patrick-hovsepian
commented
May 20, 2025
- Add a constructor that accepts raw audio sample data
- disable some warnings around self-descriptive enum names
There was a problem hiding this comment.
Welcome to SoundFlow repository! We appreciate you taking the time to contribute.
We're excited to review your pull request and look forward to collaborating with you. Please let us know if you have any questions or need any assistance.
Thank you for your contribution!
|
Thanks for taking the time to contribute to SoundFlow. I'd suggest moving the float array support to RawDataProvider instead, as AssetDataProvider & StreamDataProvider are dedicated to encoded streams to ensure they adhere to the Single Responsibility Principle. EDIT: Actually, Never Mind, I'm working on adding Float (F32), Int (S32), Short (S16), Byte (U8) raw arrays the RawDataProvider to handle different data types instead |
Adding it to the RawDataProvider was actually my first thought but I didn't want to mess with the implementation too much especially since the AssetProvider already had the raw data as a backing field. |