Skip to content

refactor: Raw audio sample support for AssetDataProvider#43

Merged
LSXPrime merged 3 commits intoLSXPrime:masterfrom
patrick-hovsepian:raw_asset
May 22, 2025
Merged

refactor: Raw audio sample support for AssetDataProvider#43
LSXPrime merged 3 commits intoLSXPrime:masterfrom
patrick-hovsepian:raw_asset

Conversation

@patrick-hovsepian
Copy link
Contributor

  • Add a constructor that accepts raw audio sample data
  • disable some warnings around self-descriptive enum names

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to SoundFlow repository! We appreciate you taking the time to contribute.

We're excited to review your pull request and look forward to collaborating with you. Please let us know if you have any questions or need any assistance.

Thank you for your contribution!

@LSXPrime
Copy link
Owner

LSXPrime commented May 22, 2025

Thanks for taking the time to contribute to SoundFlow. I'd suggest moving the float array support to RawDataProvider instead, as AssetDataProvider & StreamDataProvider are dedicated to encoded streams to ensure they adhere to the Single Responsibility Principle.

EDIT: Actually, Never Mind, I'm working on adding Float (F32), Int (S32), Short (S16), Byte (U8) raw arrays the RawDataProvider to handle different data types instead

@LSXPrime LSXPrime changed the title Raw audio sample support for AssetDataProvider refactor: Raw audio sample support for AssetDataProvider May 22, 2025
@LSXPrime LSXPrime merged commit d50a9b0 into LSXPrime:master May 22, 2025
1 check passed
@patrick-hovsepian patrick-hovsepian deleted the raw_asset branch May 22, 2025 13:26
@patrick-hovsepian
Copy link
Contributor Author

I'm working on adding Float (F32), Int (S32), Short (S16), Byte (U8) raw arrays the RawDataProvider to handle different data types instead

Adding it to the RawDataProvider was actually my first thought but I didn't want to mess with the implementation too much especially since the AssetProvider already had the raw data as a backing field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants