Fix bug introduced by #5657

include/ControllerConnection.h

@@ -37,7 +37,6 @@
 #include "JournallingObject.h"
 #include "ValueBuffer.h"
 
-class AutomatableModel;
 class ControllerConnection;
 
 typedef QVector<ControllerConnection *> ControllerConnectionVector;
@@ -48,7 +47,7 @@ class LMMS_EXPORT ControllerConnection : public QObject, public JournallingObjec
 	Q_OBJECT
 public:
 
-	ControllerConnection(Controller * _controller, AutomatableModel * contmod);
+	ControllerConnection(Controller * _controller);
 	ControllerConnection( int _controllerId );
 
 	virtual ~ControllerConnection();
@@ -112,8 +111,6 @@ public slots:
 
 	static ControllerConnectionVector s_connections;
 
-	AutomatableModel * m_controlledModel;
-
 signals:
 	// The value changed while the mixer isn't running (i.e: MIDI CC)
 	void valueChanged();

src/core/AutomatableModel.cpp

@@ -215,7 +215,7 @@ void AutomatableModel::loadSettings( const QDomElement& element, const QString&
 		}
 		if( thisConnection.isElement() )
 		{
-			setControllerConnection(new ControllerConnection((Controller*)NULL, this));
+			setControllerConnection(new ControllerConnection(nullptr));
 			m_controllerConnection->loadSettings( thisConnection.toElement() );
 			//m_controllerConnection->setTargetName( displayName() );
 		}

src/core/ControllerConnection.cpp

@@ -36,11 +36,10 @@ ControllerConnectionVector ControllerConnection::s_connections;
 
 
 
-ControllerConnection::ControllerConnection(Controller * _controller, AutomatableModel * contmod) :
+ControllerConnection::ControllerConnection(Controller * _controller) :
 	m_controller( NULL ),
 	m_controllerId( -1 ),
-	m_ownsController(false),
-	m_controlledModel(contmod)
+	m_ownsController(false)
 {
 	if( _controller != NULL )
 	{
@@ -124,12 +123,6 @@ void ControllerConnection::setController( Controller * _controller )
 	m_ownsController =
 		(_controller->type() == Controller::MidiController);
 
-	connect(Engine::getSong(), SIGNAL(stopped()),
-		m_controlledModel, SLOT(setUseControllerValue()),
-			Qt::UniqueConnection);
-
-	m_controlledModel->setUseControllerValue(true);
-
 	// If we don't own the controller, allow deletion of controller
 	// to delete the connection
 	if( !m_ownsController ) {

src/core/Song.cpp

@@ -405,17 +405,15 @@ void Song::processAutomations(const TrackList &tracklist, TimePos timeStart, fpp
 		}
 	}
 
-	// Checks if an automated model stopped being automated by automation patterns
-	// so we can move the control back to any connected controller again
+	// Moves the control of the models that were processed earlier to their controllers.
+	// If they get processed again, setAutomatedValue() will move the control back
+	// to the automation.
 	if (!m_oldAutomatedValues.isEmpty())
 	{
 		for (auto it = m_oldAutomatedValues.begin(); it != m_oldAutomatedValues.end(); it++)
 		{
 			AutomatableModel * am = it.key();
-			if (am->controllerConnection() && !values.contains(am))
-			{
-				am->setUseControllerValue(true);
-			}
+			am->setUseControllerValue(true);
 		}
 	}
 	m_oldAutomatedValues = values;
@@ -427,10 +425,6 @@ void Song::processAutomations(const TrackList &tracklist, TimePos timeStart, fpp
 		{
 			it.key()->setAutomatedValue(it.value());
 		}
-		else if (!it.key()->useControllerValue())
-		{
-			it.key()->setUseControllerValue(true);
-		}
 	}
 }
 
@@ -687,6 +681,18 @@ void Song::stop()
 	// remove all note-play-handles that are active
 	Engine::mixer()->clear();
 
+	// Moves the control of the models that were processed on the last frame
+	// back to their controllers.
+	if (!m_oldAutomatedValues.isEmpty())
+	{
+		for (auto it = m_oldAutomatedValues.begin(); it != m_oldAutomatedValues.end(); it++)
+		{
+			AutomatableModel * am = it.key();
+			am->setUseControllerValue(true);
+		}
+	}
+	m_oldAutomatedValues.clear();
+
 	m_playMode = Mode_None;
 
 	emit stopped();
@@ -886,6 +892,9 @@ void Song::clearProject()
 	m_masterPitchModel.reset();
 	m_timeSigModel.reset();
 
+	// Clear the m_oldAutomatedValues AutomatedValueMap
+	m_oldAutomatedValues.clear();
+
 	AutomationPattern::globalAutomationPattern( &m_tempoModel )->clear();
 	AutomationPattern::globalAutomationPattern( &m_masterVolumeModel )->
 									clear();

src/gui/AutomatableModelView.cpp

@@ -33,7 +33,6 @@
 #include "embed.h"
 #include "GuiApplication.h"
 #include "MainWindow.h"
-#include "Song.h"
 #include "StringPairDrag.h"
 #include "Clipboard.h"
 
@@ -229,7 +228,7 @@ void AutomatableModelViewSlots::execConnectionDialog()
 			// New
 			else
 			{
-				ControllerConnection* cc = new ControllerConnection(d.chosenController(), m);
+				ControllerConnection* cc = new ControllerConnection(d.chosenController());
 				m->setControllerConnection( cc );
 				//cc->setTargetName( m->displayName() );
 			}
@@ -251,12 +250,8 @@ void AutomatableModelViewSlots::removeConnection()
 
 	if( m->controllerConnection() )
 	{
-		disconnect(Engine::getSong(), SIGNAL(stopped()),
-			   m, SLOT(setUseControllerValue()));
-
 		delete m->controllerConnection();
 		m->setControllerConnection( NULL );
-		emit m->dataChanged();
 	}
 }