Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug introduced by #5657 #5982

Merged
merged 5 commits into from
Apr 21, 2021

Commits on Apr 12, 2021

  1. Fix bug introduced by LMMS#5657

    	There was a bug introduced by LMMS#5657 where reloading a project
    and playing it could cause a Segmentation Fault crash. After some
    debugging, @DomClark tracked the issue to be likely a use-after-free
    being caused by m_oldAutomatedValues not being cleared when the project
    was loaded again.
    	This commit adds a line to clear the m_oldAutomatedValues map on
    Song::clearProject(), which is called from Song::loadProject().
    
    Co-authored-by: Dominic Clark <mrdomclark@gmail.com>
    IanCaio and DomClark committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    6371c90 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2021

  1. Make some changes to the way LMMS#5657 works

    	Now, instead of using a Signal/Slot connection to move the
    control of the models back to the controllers, every time the song is
    processing the automations, the control of the models that were
    processed in the last cycle are moved back to the controller. The same
    is done under Song::stop(), so the last cycle models control is moved
    back to the controller.
    	That removes the need to have a pointer to the controlled model
    in the controller object.
    IanCaio committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    fb896ff View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2021

  1. Addresses Dom review

    	Adds mixer model change request to avoid race condition.
    	Revert changes to processAutomations.
    IanCaio committed Apr 18, 2021
    Configuration menu
    Copy the full SHA
    bad05be View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2eaaeff View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2021

  1. Removes unnecessary conditional

    	Since we are iterating from QVector::begin() to QVector::end()
    there's no need to check if it's empty first.
    IanCaio committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    04f5c63 View commit details
    Browse the repository at this point in the history