piano roll redraw glitch

[zapa1928]

Piano-Roll does not redraw correctly

see file.

happened in lmms 1.0.3 win7 64 and 32 versions

[Spekular]

Change your theme directory to the new one, you're most likely still on the old one.

[tresf]

You didn't uninstall 0.4.x properly. :)

[zapa1928]

Thanks. Uninstalling helped.

2014-10-02 21:08 GMT+02:00 Tres Finocchiaro notifications@github.com:

You didn't uninstall 0.4.x properly. :)

—
Reply to this email directly or view it on GitHub
#1187 (comment).

[tresf]

Ok, I reproduced it.

I think this is due to the 32-bit vs. 64-bit paths on Windows. It appears when both the 32-bit and 64-bit versions of the software are installed, the artwork never gets overridden and this bug occurs.

@diizy, we already have a centralized function which loads our pixmaps, right? Can't we just fallback on the default artwork directory rather than allowing these null artifacts? I know this is perceived as a user-error, but if we have the ability to fix missing pixmaps, this helps theme creators too IMO as they can continue using an old theme with the software until the author of the theme has had time to accommodate the changes.

[tresf]

Edit: Closed via #1412.

So I looked into the code and it appears to fallback on the default directory if the file doesn't exist per:

https://github.com/LMMS/lmms/blob/stable-1.1/src/gui/embed.cpp#L64

So I believe this issue is most likely related to incompatible themes rather than missing pixmaps. Still investigating...