Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS-1698 add support for temporary accommodation blocks #91

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

LBHTKarki
Copy link
Contributor

@LBHTKarki LBHTKarki commented Jan 29, 2025

Link to JIRA ticket

TS-1698

Describe this PR

What is the problem we're trying to solve

This adds support for the same three new properties for temporary accommodation already implemented in the asset information api. Please see PR and PR

What changes have we introduced

  1. Adds optional isTemporaryAccommodationBlock, temporaryAccommodationParentAssetId and isPartOfTemporaryAccommodationBlock properties to QueryableAssetManagement. These properties are required in order to implement front end changes required for showing block details.

Checklist

  • Added end-to-end (i.e. integration) tests where necessary e.g to test complete functionality of a newly added feature
  • Added tests to cover all new production code
  • Added comments to the README or updated relevant documentation (add link to documentation), where necessary.
  • Checked all code for possible refactoring
  • Code pipeline builds correctly

Follow up actions after merging PR

Update the search listener and API by implementing these new properties.

@LBHTKarki LBHTKarki requested a review from a team as a code owner January 29, 2025 13:03
@LBHTKarki LBHTKarki merged commit 686457b into main Jan 29, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants