Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS-1921 Add support for IsPartOfTemporaryAccommodationBlock flag in AssetManagement #158

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

LBHTKarki
Copy link
Contributor

@LBHTKarki LBHTKarki commented Jan 29, 2025

Link to JIRA ticket

TS-1921

Describe this PR

What is the problem we're trying to solve

Please see the context in this PR for the updated asset shared package.

What changes have we introduced

  1. Add support for new IsPartOfTemporaryAccommodationBlock property in AssetManagement
  2. Update the AddAssetRequestValidator with business rules that apply to the IsPartOfTemporaryAccommodationBlock property
  3. Update the Hackney.Shared.Asset package to version 0.44.0 which adds the new property

Checklist

  • Added end-to-end (i.e. integration) tests where necessary e.g to test complete functionality of a newly added feature
  • Added tests to cover all new production code
  • Added comments to the README or updated relevant documentation (add link to documentation), where necessary.
  • Checked all code for possible refactoring
  • Code pipeline builds correctly

Follow up actions after merging PR

N/A

@LBHTKarki LBHTKarki requested a review from a team as a code owner January 29, 2025 11:57
@LBHTKarki LBHTKarki merged commit e02909b into master Jan 29, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants