Repository navigation
fix: restore ordinary window geometry and Windows startup position - #460
Draft
WilliamWang1721 wants to merge 6 commits into
Draft
WilliamWang1721 wants to merge 6 commits into
WilliamWang1721 wants to merge 6 commits into
Conversation
This was referenced Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result / 用户结果
Remember ordinary window size across full process exit, restore its Windows position on a still-attached display, and honor explicit Lua
window.position. Explicit grid/position settings take priority over saved geometry. Refs #105, #151, #312; grid dimensions and Quick Terminal's independent sizing were already implemented and are not claimed as new fixes.Design / 设计边界
Geometry shares the existing atomic session document. Only the first ordinary cold-start window consumes it; new windows, Quick Terminal and administrator isolation retain their own policy. Save normal bounds rather than maximized/fullscreen viewport dimensions, preserve an empty last-window snapshot without restoring closed shells, and clamp on the selected display. Optional JSON position/display fields keep old sessions compatible. Ownership and coordinate note.
Windows saves physical desktop position and logical size using the pinned GPUI normal-placement contract. Non-Windows position restoration is outside this change. Hidden Windows configuration placement waits until activation consumes GPUI's cached placement.
Evidence / 验证依据
f99fcbac, Windows tests pending at creation. Formatting, architecture against9dd3d649, and platform branch gate passed. Head0afbbde9applies the exact remote formatting and tightens the branch budget.Required Review / 必须确认
AI-assisted implementation: GPT-6.1 SOL. Reasoning effort was not verified. No merge or approval is requested from automation.