-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dnspolicy section name support #961
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,135 @@ | ||
| package controllers | ||
|
|
||
| import ( | ||
| "context" | ||
| "testing" | ||
|
|
||
| externaldns "sigs.k8s.io/external-dns/endpoint" | ||
|
|
||
| kuadrantdnsv1alpha1 "github.com/kuadrant/dns-operator/api/v1alpha1" | ||
| ) | ||
|
|
||
| func Test_canUpdateDNSRecord(t *testing.T) { | ||
| tests := []struct { | ||
| name string | ||
| current *kuadrantdnsv1alpha1.DNSRecord | ||
| desired *kuadrantdnsv1alpha1.DNSRecord | ||
| want bool | ||
| }{ | ||
| { | ||
| name: "different root hosts", | ||
| current: &kuadrantdnsv1alpha1.DNSRecord{ | ||
| Spec: kuadrantdnsv1alpha1.DNSRecordSpec{ | ||
| RootHost: "foo.example.com", | ||
| }, | ||
| }, | ||
| desired: &kuadrantdnsv1alpha1.DNSRecord{ | ||
| Spec: kuadrantdnsv1alpha1.DNSRecordSpec{ | ||
| RootHost: "bar.example.com", | ||
| }, | ||
| }, | ||
| want: false, | ||
| }, | ||
| { | ||
| name: "same root hosts", | ||
| current: &kuadrantdnsv1alpha1.DNSRecord{ | ||
| Spec: kuadrantdnsv1alpha1.DNSRecordSpec{ | ||
| RootHost: "foo.example.com", | ||
| }, | ||
| }, | ||
| desired: &kuadrantdnsv1alpha1.DNSRecord{ | ||
| Spec: kuadrantdnsv1alpha1.DNSRecordSpec{ | ||
| RootHost: "foo.example.com", | ||
| }, | ||
| }, | ||
| want: true, | ||
| }, | ||
| { | ||
| name: "different record type same dnsnames", | ||
| current: &kuadrantdnsv1alpha1.DNSRecord{ | ||
| Spec: kuadrantdnsv1alpha1.DNSRecordSpec{ | ||
| Endpoints: []*externaldns.Endpoint{ | ||
| { | ||
| DNSName: "foo.example.com", | ||
| RecordType: "A", | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| desired: &kuadrantdnsv1alpha1.DNSRecord{ | ||
| Spec: kuadrantdnsv1alpha1.DNSRecordSpec{ | ||
| Endpoints: []*externaldns.Endpoint{ | ||
| { | ||
| DNSName: "foo.example.com", | ||
| RecordType: "CNAME", | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| want: false, | ||
| }, | ||
| { | ||
| name: "same record type same dnsnames", | ||
| current: &kuadrantdnsv1alpha1.DNSRecord{ | ||
| Spec: kuadrantdnsv1alpha1.DNSRecordSpec{ | ||
| Endpoints: []*externaldns.Endpoint{ | ||
| { | ||
| DNSName: "foo.example.com", | ||
| RecordType: "A", | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| desired: &kuadrantdnsv1alpha1.DNSRecord{ | ||
| Spec: kuadrantdnsv1alpha1.DNSRecordSpec{ | ||
| Endpoints: []*externaldns.Endpoint{ | ||
| { | ||
| DNSName: "foo.example.com", | ||
| RecordType: "A", | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| want: true, | ||
| }, | ||
| { | ||
| name: "multiple endpoints", | ||
| current: &kuadrantdnsv1alpha1.DNSRecord{ | ||
| Spec: kuadrantdnsv1alpha1.DNSRecordSpec{ | ||
| Endpoints: []*externaldns.Endpoint{ | ||
| { | ||
| DNSName: "foo.example.com", | ||
| RecordType: "A", | ||
| }, | ||
| { | ||
| DNSName: "baz.example.com", | ||
| RecordType: "CNAME", | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| desired: &kuadrantdnsv1alpha1.DNSRecord{ | ||
| Spec: kuadrantdnsv1alpha1.DNSRecordSpec{ | ||
| Endpoints: []*externaldns.Endpoint{ | ||
| { | ||
| DNSName: "foo.example.com", | ||
| RecordType: "A", | ||
| }, | ||
| { | ||
| DNSName: "bar.example.com", | ||
| RecordType: "CNAME", | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| want: true, | ||
| }, | ||
| } | ||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| if got := canUpdateDNSRecord(context.Background(), tt.current, tt.desired); got != tt.want { | ||
| t.Errorf("canUpdateDNSRecord() = %v, want %v", got, tt.want) | ||
| } | ||
| }) | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maleck13 fyi, because i had to do this to deal with possible changes in record type when attaching a policy to a listener that already has existing records via policy attached to a gateway, it means we could probably remove this now https://github.com/Kuadrant/kuadrant-operator/blob/main/api/v1alpha1/dnspolicy_types.go#L56 and allow switching from simple to loadbalanced without the need for manual intervention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice ok. Lets go for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do it in a different PR, will need some tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#968