fix: Remove dnspolicy lb immutable validation #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the validation on the loadBalancing field of the dnspolicy spec. Updates made as part of section name support allow the controller to handle changes to endpoint record types. It is now possible to switch from what we used to refer to as simple policy types (loadBalancing field not set) to loadbalanced (loadBalancing field set) and vice versa without deleting and re-creating the policy. Signed-off-by: Michael Nairn <mnairn@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the immutable validation on the loadBalancing field of the dnspolicy spec.
Updates made as part of section name support allow the controller to handle changes to endpoint record types, so it's now possible to switch from what we used to refer to as simple policy types (loadBalancing field not set) to loadbalanced (loadBalancing field set) and vice versa without deleting and re-creating the policy.