Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defimpl with for: list indexes name for each list entry #393

Merged
merged 2 commits into from
Aug 28, 2016
Merged

Conversation

KronicDeth
Copy link
Owner

@KronicDeth KronicDeth commented Aug 28, 2016

Fixes #388

Changelog

Enhancements

  • In addition to StubBased#canonicalName, there now also StubBased#canonicalNames, for when a call defines multiple canonical names, as is the case for defimpl <PROTOCOL>, for: [<TYPE>, ...].

Bug Fixes

  • defimpl <PROTOCOL>, for: [<TYPE>, ...] generates multiple canonical names, which are stored in the stub index.

If `defimpl` has a list for it's `for:` keyword argument, then index all
canonical names derived from all the elements of the `for:`.
@KronicDeth KronicDeth added this to the v4.3.0 milestone Aug 28, 2016
@KronicDeth KronicDeth self-assigned this Aug 28, 2016
@KronicDeth KronicDeth merged commit 82a5702 into master Aug 28, 2016
@KronicDeth KronicDeth deleted the 388 branch August 28, 2016 20:42
KronicDeth added a commit that referenced this pull request Aug 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant